Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced-Search-layout-not-proper #20810

Closed
wants to merge 6 commits into from
Closed

Advanced-Search-layout-not-proper #20810

wants to merge 6 commits into from

Conversation

amol2jcommerce
Copy link
Contributor

@amol2jcommerce amol2jcommerce commented Jan 30, 2019 •
edited
Loading

Description (*)

Fixed Issues (if relevant)

  1. Advanced Search layout not proper #20809: Advanced Search layout not proper

Manual testing scenarios (*)

  1. Click Advanced Search link in footer

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

This was referenced Jan 30, 2019
Closed
Merged
@VladimirZaets VladimirZaets self-assigned this Jan 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4060 has been created to process this Pull Request

@VladimirZaets
Copy link
Contributor

Hi @amol2jcommerce. Thanks for collaboration.
We check manually this case and found that behavior (width) is inconsistent on Contact Us form and Advanced Search pages on a tablet view (768 x 1024)

@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce, here is your Magento instance.
Admin access: https://i-20810-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce, here is your new Magento instance.
Admin access: https://pr-20810.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ amol2jcommerce
❌ amol 2jcommerce
❌ Amol Chaudhari

amol 2jcommerce, Amol Chaudhari seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@amol2jcommerce
Copy link
Contributor Author

Hi @VladimirZaets I update branch & sign CLA. please review.

@amol2jcommerce
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce, here is your new Magento instance.
Admin access: https://pr-20810.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@VladimirZaets
Copy link
Contributor

@amol2jcommerce currently I see commits from two accounts (❌ amol 2jcommerce
❌ Amol Chaudhari ) that are not signed CLA

@amol2jcommerce
Copy link
Contributor Author

Hi @VladimirZaets, I closed this PR due to committed from two different accounts and that account didn't sign CLA. We generate New PR #21611 for this & sign CLA account.

@ghost
Copy link

ghost commented Mar 7, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Partner: Two Jay partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amol2jcommerce @magento-engcom-team @VladimirZaets @magento-cicd2